-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAN Copy Updates #1924
SAN Copy Updates #1924
Conversation
/gcbrun |
@@ -28,7 +28,11 @@ | |||
> | |||
<v-row class="pt-6"> | |||
<v-col class="pa-4 pl-5 summary-text"> | |||
<p> | |||
<p v-if="isSecurityActNotice"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Future state to expand on which PPR reg(s) have this copy, pending design review i think. Potentially all Crown Charge as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All reg types can have a partial discharge if they have more than 1 active debtor. I would be surprised if Kevin is okay with this rule for other registration types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy that, Sara had flagged this in designs with some potential future implementations. Will 100% defer to Kevin tho! For now, only SANs :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Temporary Url for review: https://bcregistry-assets-dev--pr-1924-p1nj9j1m.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Issue #: /bcgov/entity#21555
Description of changes:
Issue #: /bcgov/entity#21578
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).