Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAN Copy Updates #1924

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Conversation

cameron-eyds
Copy link
Collaborator

Issue #: /bcgov/entity#21555
Description of changes:

  • Copy and UXA Updates for SAN Flow

Issue #: /bcgov/entity#21578
Description of changes:

  • Payload filtering of DELETED sections

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@cameron-eyds cameron-eyds self-assigned this Jun 7, 2024
@cameron-eyds
Copy link
Collaborator Author

/gcbrun

@@ -28,7 +28,11 @@
>
<v-row class="pt-6">
<v-col class="pa-4 pl-5 summary-text">
<p>
<p v-if="isSecurityActNotice">
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future state to expand on which PPR reg(s) have this copy, pending design review i think. Potentially all Crown Charge as well?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reg types can have a partial discharge if they have more than 1 active debtor. I would be surprised if Kevin is okay with this rule for other registration types.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy that, Sara had flagged this in designs with some potential future implementations. Will 100% defer to Kevin tho! For now, only SANs :)

Copy link
Collaborator

@dimak1 dimak1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1924-p1nj9j1m.web.app

Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@cameron-eyds cameron-eyds merged commit bd6bf1f into bcgov:main Jun 7, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants