-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use sbc-common-components v4.0.7 #1952
Conversation
/gcbrun |
Temporary Url for review: https://bcregistry-assets-dev--pr-1952-go9it72q.web.app |
Hey @cameron-eyds, in preview link, the hero image is not showing up (broken url). However in local dev, it it's here. I'm trying to investigate, so if you have some ideas, please let me know. Thanks! |
Will have a look! |
@dimak1 If you want to test this locally you can as well, in your terminal So, to get this to work you may need to do a few things, update the common component path: *edit: you can also alias back to sbc if you would prefer to not store the image locally Also, if we want to use the v-img, we will need a small configuration update in our project. Vite-Vuetify preset can transform the aliased paths. ie in our Vite config: |
c0c2d61
to
05f61c2
Compare
/gcbrun |
Temporary Url for review: https://bcregistry-assets-dev--pr-1952-go9it72q.web.app |
Issue #:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).