Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sbc-common-components v4.0.7 #1952

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

dimak1
Copy link
Collaborator

@dimak1 dimak1 commented Jun 26, 2024

Issue #:

Description of changes:

  • Upgrade sbc-common-components which fixes the Registries Account Login page

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@dimak1 dimak1 self-assigned this Jun 26, 2024
@dimak1
Copy link
Collaborator Author

dimak1 commented Jun 26, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1952-go9it72q.web.app

@dimak1
Copy link
Collaborator Author

dimak1 commented Jun 26, 2024

Hey @cameron-eyds, in preview link, the hero image is not showing up (broken url). However in local dev, it it's here. I'm trying to investigate, so if you have some ideas, please let me know. Thanks!

@cameron-eyds
Copy link
Collaborator

Hey @cameron-eyds, in preview link, the hero image is not showing up (broken url). However in local dev, it it's here. I'm trying to investigate, so if you have some ideas, please let me know. Thanks!

Will have a look!

@cameron-eyds
Copy link
Collaborator

cameron-eyds commented Jun 26, 2024

@dimak1
It looks like a potential issue with the src path in the common component. As is, it's looking for the asset with a relative path and while this may be an accurate path in our local builds, a vite production build will (probably) differ. I would recommend going with an alias path for the static assets, so it's always pulling from the same place regardless of build.

If you want to test this locally you can as well, in your terminal npm run build to create a production build and npm run preview to then view it in the browser.

So, to get this to work you may need to do a few things, update the common component path:
Screenshot 2024-06-26 at 10 45 57 AM

*edit: you can also alias back to sbc if you would prefer to not store the image locally
ie @sbc/ That should work as well

Also, if we want to use the v-img, we will need a small configuration update in our project. Vite-Vuetify preset can transform the aliased paths. ie in our Vite config:

Screenshot 2024-06-26 at 10 45 32 AM

@dimak1 dimak1 force-pushed the feat/upgrade-sbc-comm-components branch from c0c2d61 to 05f61c2 Compare June 26, 2024 22:32
@dimak1
Copy link
Collaborator Author

dimak1 commented Jun 26, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1952-go9it72q.web.app

@dimak1 dimak1 changed the title Use sbc-common-components v4.0.6 Use sbc-common-components v4.0.7 Jun 27, 2024
@dimak1 dimak1 merged commit 2a6fb08 into bcgov:main Jun 27, 2024
4 of 5 checks passed
@dimak1 dimak1 deleted the feat/upgrade-sbc-comm-components branch June 27, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants