Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y Unit Testing - Timeboxed #2014

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

cameron-eyds
Copy link
Collaborator

Issue #: /bcgov/entity#17892

Description of changes:

  • Implements Axe unit testing integration
  • This was time-boxed, to give us an idea of what sort of scope we are dealing with in order to apply an A11Y unit test to our test suites.
  • After a few unit tests, typical results required a dozen small items to fix but often in components that nested and not always the component subject of the test itself. This is due to a 'mounted' approach to unit testing which better supports our component library Vuetify.
  • Now that we have an idea of how and how much, we can properly estimate the remaining tests to tackle over time, or find a way to include in future tasks.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@cameron-eyds cameron-eyds self-assigned this Sep 3, 2024
@cameron-eyds
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-2014-mi67kmwo.web.app

Copy link
Collaborator

@flutistar flutistar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@cameron-eyds cameron-eyds merged commit 09b967b into bcgov:main Sep 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants