Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added hidden elements for ARIA #2018

Merged
merged 5 commits into from
Sep 6, 2024
Merged

added hidden elements for ARIA #2018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
31c0a18
added hidden elements for ARIA
flutistar Sep 5, 2024
b4985eb
addressed code styling issue
flutistar Sep 6, 2024
54d7bb2
addressed code styling issue
flutistar Sep 6, 2024
0d22f92
addressed code styling issue
flutistar Sep 6, 2024
0d075fd
fixed unit test error
flutistar Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ppr-ui/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ppr-ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ppr-ui",
"version": "3.2.52",
"version": "3.2.53",
"private": true,
"appName": "Assets UI",
"sbcName": "SBC Common Components",
Expand Down
65 changes: 52 additions & 13 deletions ppr-ui/src/components/tables/SearchHistory.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
class="pr-2 mt-n1"
color="#212529"
aria-hidden="false"
:aria-label="isPprSearch(item) ? 'PPR Search' : 'MHR Search'"
:aria-label="headers[0].text + ',' + (isPprSearch(item) ? 'PPR Search' : 'MHR Search')"
role="img"
>
{{ isPprSearch(item) ? 'mdi-account-details' : 'mdi-home' }}
Expand All @@ -58,29 +58,53 @@
</v-col>
</v-row>
</td>
<td v-if="isPprSearch(item)">
{{ displayType(item.searchQuery.type) }}
</td>
<td v-else>
{{ displayMhrType(item.searchQuery.type) }}
<td>
<span
class="aria-label-only"
aria-hidden="false"
>
{{ headers[1].text }}
</span>
{{ isPprSearch(item) ? displayType(item.searchQuery.type) : displayMhrType(item.searchQuery.type) }}
</td>
<td>
<span
class="aria-label-only"
aria-hidden="false"
>
{{ headers[2].text }}
</span>
<span v-if="isPprSearch(item)">Personal Property</span>
<span v-else>Manufactured Homes</span>
</td>
<td>
<span
class="aria-label-only"
aria-hidden="false"
>
{{ headers[3].text }}
</span>
<span v-if="!item.inProgress || isSearchOwner(item)">
{{ displayDate(item.searchDateTime) }}
</span>
<span v-else>Pending</span>
</td>
<td v-if="isStaff">
{{ item.username }}
</td>
<td v-else>
{{ item.searchQuery.clientReferenceId || '-' }}
<td>
<span
class="aria-label-only"
aria-hidden="false"
>
{{ headers[4].text }}
</span>
{{ isStaff ? item.username : item.searchQuery.clientReferenceId || '-' }}
</td>
<td>
<span
class="aria-label-only"
aria-hidden="false"
>
{{ headers[5].text }}
</span>
<span v-if="!item.inProgress || isSearchOwner(item)">
{{ item.totalResultsSize }}
</span>
Expand All @@ -91,6 +115,12 @@
>-</span>
</td>
<td>
<span
class="aria-label-only"
aria-hidden="false"
>
{{ headers[6].text }}
</span>
<span v-if="(!item.inProgress || isSearchOwner(item)) && item.exactResultsSize >= 0">
{{ item.exactResultsSize }}
</span>
Expand All @@ -101,8 +131,14 @@
>-</span>
</td>
<td>
<span
class="aria-label-only"
aria-hidden="false"
>
{{ headers[7].text }}
</span>
<span v-if="!item.inProgress || isSearchOwner(item)">
{{ item.selectedResultsSize }}
{{ item.selectedResultsSize }}

Check warning on line 141 in ppr-ui/src/components/tables/SearchHistory.vue

View workflow job for this annotation

GitHub Actions / linting (20.5.1) 

Expected indentation of 20 spaces but found 21 spaces
</span>
<span
v-else
Expand All @@ -119,7 +155,7 @@
variant="plain"
:ripple="false"
:loading="item.loadingPDF"
aria-label="Download PDF"
aria-label="Download report, Download PDF"
@click="downloadPDF(item)"
>
<img src="@/assets/svgs/pdf-icon-blue.svg">
Expand Down Expand Up @@ -541,4 +577,7 @@
.dontRead {
speak: none!important;
}
.aria-label-only {
display: none
}
</style>
Loading