Document Record Service - Cont. In Integration #3242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutistar
changed the title
seeker25
reviewed
Feb 5, 2025
auth-web/src/components/auth/staff/continuation-application/HomeJurisdictionInformation.vue
Outdated
Show resolved
Hide resolved
|
seeker25
reviewed
Feb 5, 2025
| @@ -314,13 +315,23 @@ export default defineComponent({ | |||
| if (!documentKey || !documentName) return // safety check | |||
|
|
|||
| state.isDownloading = true | |||
| await BusinessService.downloadDocument(documentKey, documentName).catch(error => { | |||
| try { | |||
| if (DRS_ID_PATTERN.test(documentKey)) { | |||
There was a problem hiding this comment.
do we need a feature flag for this, or can it be pushed out to prod next week if needed etc?
There was a problem hiding this comment.
@seeker25
I changed the base branch since we are holding the updates on feature branch on create-ui repo.
|
another thing to note, product/payment changes will probably have to sit on TEST for a while - just a heads up |
|
Ok keep in mind anytime you merge into
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
bcgov/entity#24640
Description of changes:
My name is Brandon Galli from Assets team.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).