Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small bug fixes #3272

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Small bug fixes #3272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion auth-api/src/auth_api/services/keycloak.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,10 @@ def remove_from_account_holders_group(keycloak_guid: str = None, **kwargs):
keycloak_guid: Dict = user_from_context.sub

if Role.ACCOUNT_HOLDER.value in user_from_context.roles:
KeycloakService.remove_user_from_group(keycloak_guid, GROUP_ACCOUNT_HOLDERS)
try:
KeycloakService.remove_user_from_group(keycloak_guid, GROUP_ACCOUNT_HOLDERS)
except Exception as err:
logger.error(f"Error removing user {user_from_context.sub} from account holders group: {err}")

@staticmethod
@user_context
Expand Down
1 change: 1 addition & 0 deletions auth-api/src/auth_api/services/membership.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@ def send_notification_to_member(self, origin_url, notification_type):
error_msg = f"No user contact record for user id {self._model.user_id}"
logger.error(error_msg)
logger.error("<send_notification_to_member failed")
return
recipient = self._model.user.contacts[0].contact.email
app_url = f"{origin_url}/"
notification_type_for_mailer = ""
Expand Down
Loading