25229 - Remove Learn More button in Business Registry Marketing page #3280
Conversation
Signed-off-by: Qin <[email protected]>
Signed-off-by: Qin <[email protected]>
Signed-off-by: Qin <[email protected]>
|
|
/gcbrun |
| @@ -66,16 +60,9 @@ | |||
| <script lang="ts"> | |||
| import { Component, Vue } from 'vue-property-decorator' | |||
| import ConfigHelper from '@/util/config-helper' | |||
| import LearnMoreButton from '@/components/auth/common/LearnMoreButton.vue' | |||
There was a problem hiding this comment.
Do you think this component should be deleted?
There was a problem hiding this comment.
It's used in other places
I think these links are needed, right?
There was a problem hiding this comment.
Oh! Good catch.
Yes, please check with Janis.
I assume those other link buttons don't work either?
There was a problem hiding this comment.
These links are working and directing to different pages, which seems needed and working well to me.
https://dev.account.bcregistry.gov.bc.ca/request-name
There was a problem hiding this comment.
Oh, it's a generic button with different URLs.
Well, maybe the other instances are OK. Confirm with Janis.
There was a problem hiding this comment.
Sure! Janis is out of office, will add a note and confirm with her next week.
There was a problem hiding this comment.
I recommend you merge this PR and create a new ticket if more changes are needed after you chat with Janis.
There was a problem hiding this comment.
Sure, could you please merge it? I don't have admin access, thank you!
|
Arwen, please add a comment to your ticket, addressed to @seeker25 , to include it in their next deployment. |
|
Temporary Url for review: https://bcregistry-account-dev--pr-test-3280-mhafd0ox.web.app |
|
Temporary Url for review: https://bcregistry-account-dev--pr-3280-b74kvnlh.web.app |
|
Test: Before: Removed: |
Issue #:
bcgov/entity#25229
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).