Warning fixes, update deps (#1604)

bcgov · Jul 5, 2024 · 11b99ac · 11b99ac
1 parent b854569
commit 11b99ac
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 10 deletions.
diff --git a/jobs/payment-jobs/poetry.lock b/jobs/payment-jobs/poetry.lock
diff --git a/pay-api/src/pay_api/models/base_model.py b/pay-api/src/pay_api/models/base_model.py
@@ -60,4 +60,6 @@ def rollback():
     @classmethod
     def find_by_id(cls, identifier: int):
         """Return model by id."""
-        return db.session.get(cls, identifier)
+        if identifier:
+            return db.session.get(cls, identifier)
+        return None
diff --git a/pay-api/src/pay_api/models/statement.py b/pay-api/src/pay_api/models/statement.py
@@ -98,4 +98,4 @@ class Meta:  # pylint: disable=too-few-public-methods
     to_date = fields.Date(tzinfo=pytz.timezone(LEGISLATIVE_TIMEZONE))
     is_overdue = fields.Boolean()
     payment_methods = fields.List(fields.String())
-    amount_owing = fields.Float(missing=0)
+    amount_owing = fields.Float(load_default=0)
diff --git a/pay-api/src/pay_api/services/payment_account.py b/pay-api/src/pay_api/services/payment_account.py
@@ -97,8 +97,7 @@ def __getattr__(self, name):
         """Dynamic way of getting the properties from the DAO, anything not in __init__."""
         if hasattr(self._dao, name):
             return getattr(self._dao, name)
-        current_app.logger.warning('Attribute %s not found.', name)
-        return None
+        raise AttributeError(f'Attribute {name} not found.')
 
     def __setattr__(self, name, value):
         """Dynamic way of setting the properties from the DAO."""

diff --git a/pay-queue/poetry.lock b/pay-queue/poetry.lock