Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

19513 - Add CSV Feedback monitoring #1598

Merged
merged 4 commits into from
Jul 5, 2024
Merged

19513 - Add CSV Feedback monitoring #1598

merged 4 commits into from
Jul 5, 2024

Conversation

Jxio
Copy link
Collaborator

@Jxio Jxio commented Jul 3, 2024 •
edited by seeker25
Loading

Issue #:
bcgov/entity#19513

Description of changes:
Relies on bcgov/sbc-auth#2891

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@Jxio Jxio self-assigned this Jul 3, 2024
seeker25
seeker25 approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@seeker25 seeker25 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes, looks good.. still need an explanation on the EJV_ERROR message.. we're you creating another PR in Account-mailer? or it just works as is?

bcgov/sbc-auth#2891

@seeker25
Copy link
Collaborator

seeker25 commented Jul 3, 2024 •
edited
Loading

Please Use notify-api directly for this, reference the statement jobs.. they have some notify-api integrations

@Jxio Jxio marked this pull request as draft July 3, 2024 17:31
@Jxio Jxio marked this pull request as ready for review July 4, 2024 00:00
@seeker25
Copy link
Collaborator

seeker25 commented Jul 4, 2024

CI

@seeker25
Copy link
Collaborator

seeker25 commented Jul 5, 2024

Good stuff looks great Jia

@seeker25 seeker25 merged commit 4f78c85 into bcgov:main Jul 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seeker25 seeker25 seeker25 approved these changes

@ochiu ochiu Awaiting requested review from ochiu ochiu is a code owner

@rodrigo-barraza rodrigo-barraza Awaiting requested review from rodrigo-barraza rodrigo-barraza is a code owner

@avni-work avni-work Awaiting requested review from avni-work

Assignees

@Jxio Jxio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jxio @seeker25