[TC-0059] Auth Guard #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
chelsea-EYDS
commented
Dec 16, 2023
chelsea-EYDS
commented
- Checking auth token on all routes that are not annotated with the public decorator
- Validating auth token
- Checking Reflector to see if route is annotated with a Roles decorator
- Validating user assigned role if the current route requires a role
chelsea-EYDS
force-pushed
the
TC-66
branch
2 times, most recently
from
90b8e82 to
d363026
Compare
fw-noel
reviewed
Dec 19, 2023
| throw new UnauthorizedException(); | ||
| } | ||
|
|
||
| //YODO check expiry |
There was a problem hiding this comment.
This would be pretty trivial, no?
backend/src/auth/auth.guard.ts
Outdated
| throw new UnauthorizedException(); | ||
| } | ||
|
|
||
| if (payload.aud !== 'account') { |
There was a problem hiding this comment.
This seems like the wrong thing to check? I think authorized party is the thing to check azp
| import { SetMetadata } from '@nestjs/common'; | ||
| import { Metadata } from './metadata'; | ||
|
|
||
| export const Public = () => SetMetadata(Metadata.IS_PUBLIC, true); |
There was a problem hiding this comment.
can we change to PUBLIC_ENDPOINT just for clarity
fw-noel
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.