add elevation to stations json & update tests

bcgov · brettedw · Nov 23, 2023 · Nov 16, 2023 · Nov 16, 2023 · Nov 16, 2023
commit b566782101dfe643d3f7dda14d8625fe3fc56c9f
diff --git a/api/app/data/weather_stations.json b/api/app/data/weather_stations.json
diff --git a/...sts/weather_models/endpoints/test_models_predictions_most_recent_GDPS_[838]_response.json b/...sts/weather_models/endpoints/test_models_predictions_most_recent_GDPS_[838]_response.json
@@ -13,7 +13,7 @@
                     "end_month": 8,
                     "end_day": 31
                 },
-                "elevation": null,
+                "elevation": 821,
                 "wfwx_station_uuid": null,
                 "zone_code": null
             },

diff --git a/...sts/weather_models/endpoints/test_models_predictions_most_recent_GDPS_[956]_response.json b/...sts/weather_models/endpoints/test_models_predictions_most_recent_GDPS_[956]_response.json
@@ -13,7 +13,7 @@
                     "end_month": 8,
                     "end_day": 31
                 },
-                "elevation": null,
+                "elevation": 632,
                 "wfwx_station_uuid": null,
                 "zone_code": null
             },

diff --git a/...eather_models/endpoints/test_models_predictions_most_recent_RDPS_[838, 209]_response.json b/...eather_models/endpoints/test_models_predictions_most_recent_RDPS_[838, 209]_response.json
@@ -13,7 +13,7 @@
                     "end_month": 8,
                     "end_day": 31
                 },
-                "elevation": null,
+                "elevation": 791,
                 "wfwx_station_uuid": null,
                 "zone_code": null
             },
@@ -153,7 +153,7 @@
                     "end_month": 8,
                     "end_day": 31
                 },
-                "elevation": null,
+                "elevation": 821,
                 "wfwx_station_uuid": null,
                 "zone_code": null
             },

diff --git a/api/app/tests/weather_models/endpoints/test_models_predictions_summaries_response.json b/api/app/tests/weather_models/endpoints/test_models_predictions_summaries_response.json
@@ -13,7 +13,7 @@
           "end_month": 9,
           "end_day": 15
         },
-        "elevation": null,
+        "elevation": 780,
         "wfwx_station_uuid": null,
         "zone_code": null
       },

diff --git a/...p/tests/weather_models/endpoints/test_models_predictions_summaries_response_multiple.json b/...p/tests/weather_models/endpoints/test_models_predictions_summaries_response_multiple.json
@@ -13,7 +13,7 @@
           "end_month": 9,
           "end_day": 15
         },
-        "elevation": null,
+        "elevation": 780,
         "wfwx_station_uuid": null,
         "zone_code": null
       },
@@ -442,7 +442,7 @@
           "end_month": 8,
           "end_day": 31
         },
-        "elevation": null,
+        "elevation": 821,
         "wfwx_station_uuid": null,
         "zone_code": null
       },

diff --git a/api/app/tests/weather_models/test_process_grib.py b/api/app/tests/weather_models/test_process_grib.py
@@ -42,7 +42,7 @@ def test_read_single_raster_value():
     raster_band = dataset.GetRasterBand(1)
     station, value = next(processor.yield_value_for_stations(raster_band))
 
-    assert math.isclose(value, 55.976, abs_tol=0.001)
-    assert station.code == 322
+    assert station.code == 3090
+    assert math.isclose(value, 67.150, abs_tol=0.001)
 
     del dataset
diff --git a/api/scripts/station_csv_to_json.py b/api/scripts/station_csv_to_json.py
@@ -58,7 +58,8 @@ def process_stations(station_df: pd.DataFrame, ecodivisions: gpd.GeoDataFrame, c
             "lat": row['LATITUDE'],
             "long": row['LONGITUDE'],
             "ecodivision_name": ecodivision_name,
-            "core_season": core_season
+            "core_season": core_season,
+            "elevation": int(row['ELEVATION_M'])
         })
 
     # Order stations by name.