Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hourly FFMC wrapper #3317

Merged
merged 17 commits into from
Jan 18, 2024
Merged

Hourly FFMC wrapper #3317

merged 17 commits into from
Jan 18, 2024

Conversation

brettedw
Copy link
Collaborator

@brettedw brettedw commented Jan 15, 2024 •
edited
Loading

@codecov Codecov
Copy link

codecov bot commented Jan 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5e15a50) 81.77% compared to head (518533b) 81.85%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3317      +/-   ##
==========================================
+ Coverage   81.77%   81.85%   +0.08%     
==========================================
  Files         277      277              
  Lines        9558     9563       +5     
  Branches      450      450              
==========================================
+ Hits         7816     7828      +12     
+ Misses       1623     1616       -7     
  Partials      119      119

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brettedw brettedw requested review from conbrad and dgboss January 15, 2024 19:46
dgboss
dgboss reviewed Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@dgboss dgboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance we can add some tests around your code changes? I don't think we have test for anything in this file, but it's never too late to start!

api/app/fire_behaviour/cffdrs.py Outdated Show resolved Hide resolved
api/app/fire_behaviour/cffdrs.py Show resolved Hide resolved
@brettedw brettedw requested review from conbrad and dgboss January 16, 2024 16:55
conbrad
conbrad approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@conbrad conbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

dgboss
dgboss approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@dgboss dgboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@brettedw brettedw temporarily deployed to production January 18, 2024 17:50 Inactive
@brettedw brettedw merged commit 00f46d4 into main Jan 18, 2024
31 checks passed
@brettedw brettedw deleted the task/hourly_ffmc branch January 18, 2024 18:04
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
@brettedw @conbrad
Hourly FFMC wrapper (bcgov#3317)
8a368ce 
New hourly FFMC CFFDRS wrapper and tests

Co-authored-by: Conor Brady <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgboss dgboss dgboss approved these changes

@conbrad conbrad conbrad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SPIKE: Hourly FFMC Calculations; TIMEBOX = 4 Days
3 participants
@brettedw @conbrad @dgboss