Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forecast versus actual comparison icons #3449

Merged
merged 10 commits into from
Mar 6, 2024
Merged

Conversation

dgboss
Copy link
Collaborator

@dgboss dgboss commented Mar 5, 2024

  • Show a +/- icon depending on if the forecasted value is greater than or less than the actual
  • Don't show for WindDirection
  • Add darker border around editable Forecast cells

Test Links:

Landing Page
MoreCast 2.0
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 80.57%. Comparing base (d3e525c) to head (708501f).

Files Patch % Lines
...features/moreCast2/components/ColumnDefBuilder.tsx 29.41% 12 Missing ⚠️
...res/moreCast2/components/GridComponentRenderer.tsx 77.77% 3 Missing and 1 partial ⚠️
.../features/moreCast2/components/DataGridColumns.tsx 0.00% 1 Missing ⚠️
.../features/moreCast2/components/MoreCast2Column.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3449      +/-   ##
==========================================
- Coverage   80.68%   80.57%   -0.11%     
==========================================
  Files         286      287       +1     
  Lines       10199    10234      +35     
  Branches      497      506       +9     
==========================================
+ Hits         8229     8246      +17     
- Misses       1833     1851      +18     
  Partials      137      137              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dgboss dgboss requested review from brettedw and conbrad March 5, 2024 18:50
Copy link
Collaborator

@brettedw brettedw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looks good!

@dgboss
Copy link
Collaborator Author

dgboss commented Mar 6, 2024

Note that the code duplication is due to tests.

Copy link

sonarqubecloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dgboss dgboss temporarily deployed to production March 6, 2024 19:04 Inactive
@dgboss dgboss merged commit 8f9d1ef into main Mar 6, 2024
26 checks passed
@dgboss dgboss deleted the task/forecast-actual-comp/3370 branch March 6, 2024 20:57
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants