-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Morecast: Empty Cell validation #3957
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3957 +/- ##
==========================================
+ Coverage 79.92% 80.02% +0.10%
==========================================
Files 298 302 +4
Lines 11430 11472 +42
Branches 541 549 +8
==========================================
+ Hits 9135 9181 +46
+ Misses 2109 2106 -3
+ Partials 186 185 -1 ☔ View full report in Codecov by Sentry. |
web/src/features/moreCast2/components/GridComponentRenderer.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, functions great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Quality Gate passedIssues Measures |
Separate
error
intoerror
andinvalid
states, where error is a superset of invalid but includes an empty check. Forecast cells (except for grass curing and wind direction) include both error and invalid state checks.SaveForecastButton
will setisRequiredInputSet
redux flag to false if anyrowsToSave
have empty fields that are required.Forecast
cell subscribes to the state and checks it's own value for emptiness and renders itself accordingly.Note:
WindDirectionForecastCell
in it's own component otherwise it renders the cell very wide. If anyone can spot why we could remove it. It should be able to rendered the same way asValidatedGrassCureForecastCell
.react-testing-library
to recognize the error border color in cells when they are in error or invalid statesCloses #3954
Test Links:
Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator