Fix the default key display in TUI's warnPrinter
#1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define Enter explicitly as input in the TUI warning printer. This is not a functional change, it only changes the default key that is displayed to the user, to match the prompt. Enter/Return as input is treated as the default selection, as if user had pressed any of the default keys for the respective action (if there are multiple default keys defined then they are all equivalent). The first default input key is displayed to the user so they know what action is the default. In the warning printer the first default input key used to be <space>. This was a bit confusing as the prompt reads "Press return to continue." This patch defines Enter as the default input key in its own right, while also making it the first default which gets displayed to the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1055 by making the prompt match the default key that is displayed.
Not sure about the claim "Pressing space do nothing." in the original report. Pressing space still works as before and is a valid alternative.