-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add localization interface and cancelable navigation methods #40
Draft
sktometometo
wants to merge
21
commits into
bdaiinstitute:main
Choose a base branch
from
sktometometo:PR/add-cancelable-navigation-methods
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add localization interface and cancelable navigation methods #40
sktometometo
wants to merge
21
commits into
bdaiinstitute:main
from
sktometometo:PR/add-cancelable-navigation-methods
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sktometometo
force-pushed
the
PR/add-cancelable-navigation-methods
branch
from
June 30, 2023 00:03
4bd3616
to
fae31b5
Compare
sktometometo
changed the title
[WIP] add localization interface and cancelable navigation methods
Add localization interface and cancelable navigation methods
Jun 30, 2023
sktometometo
requested review from
jbarry-bdai,
heuristicus and
amessing-bdai
as code owners
June 30, 2023 01:42
Checked with our robot. |
sktometometo
force-pushed
the
PR/add-cancelable-navigation-methods
branch
from
June 30, 2023 01:44
674b514
to
cbbf0a3
Compare
heuristicus
reviewed
Jun 30, 2023
heuristicus
reviewed
Jun 30, 2023
heuristicus
reviewed
Jun 30, 2023
heuristicus
reviewed
Jun 30, 2023
heuristicus
reviewed
Jun 30, 2023
heuristicus
reviewed
Jun 30, 2023
Thanks for review! I will update the branch. |
sktometometo
force-pushed
the
PR/add-cancelable-navigation-methods
branch
from
July 1, 2023 06:40
64b9c6e
to
b7ac5a2
Compare
Rebase this branch to #48 to support |
…t_id and add result output.
Co-authored-by: Michal Staniaszek <[email protected]>
Co-authored-by: Michal Staniaszek <[email protected]>
…gate_to_command to RobotCommandData() class
sktometometo
force-pushed
the
PR/add-cancelable-navigation-methods
branch
from
July 4, 2023 05:27
b7ac5a2
to
5bc6463
Compare
Pause this PR until #44 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on pull requests below.
This PR introduces features below.
_set_localization_waypoint()
from*arg
towaypoint_id
set_localization_fiducial()
andset_localization_waypoint()
)navigate_to
interface_start_navigate_to()
and_cancel_navigate_to()
start_navigation()
andcancel_navigation()
_last_navigate_to_command
value to indicatenavigate_to
is running or not_is_moving
updateChecked with a robot by