Oc 70 fix dance interface crash #53
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgupta-bdai
requested review from
jbarry-bdai,
heuristicus and
amessing-bdai
as code owners
heuristicus
reviewed
Jul 6, 2023
|
@spnsingh I just realized that this code relies on protobuf changes that come with v3.3.0 of the SDK. Everything was working fine from my side as I had previously updated the SDK on my local system. Seems to me like we'd need to park this PR till we update to v3.3.0. Let me know how you'd like me to handle this! Really sorry for not catching this earlier. |
davidwatkins-bdai
approved these changes
Jul 12, 2023
| self, status: choreography_sequence_pb2.ChoreographyStatusResponse.Status | ||
| ) -> bool: | ||
| """Check the status message to see if dance is onging/completed, return True if dance is completed""" | ||
| ongoing_states = [ |
There was a problem hiding this comment.
Do these make sense to be defined here?
| return True, "success" | ||
|
|
||
| start = time.time() | ||
| while time.time() - start < estimated_time_seconds + 0.2: |
There was a problem hiding this comment.
Where is the 0.2 coming from?
| "Call to execute_choreography did not return completion state in stipulated time" | ||
| ) | ||
|
|
||
| except CommandTimedOutError: |
There was a problem hiding this comment.
Is this being caught exclusively from L171? If so, is there a better way to handle this control flow?
vgupta-bdai
changed the title
vgupta-bdai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved error handling for execute_dance. The function now returns instantly if anything goes wrong (e.g. robot is estopped).