Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SW-743] Add mutate_world_objects functionality to spot_wrapper #87

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

khughes-bdai
Copy link
Collaborator

@khughes-bdai khughes-bdai commented Feb 16, 2024

This allows the user to mutate Spot's world objects. Specifically, it can be used to create/delete no-go regions for Spot which are implemented as new world objects.

I have been testing this in conjunction with a follow-up PR to integrate this into Spot ROS 2. With this implementation, Spot is successfully able to receive and respond to mutate world object requests.

…the right formatting
Copy link
Collaborator Author

khughes-bdai commented Feb 16, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link
Collaborator

@bhung-bdai bhung-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with comments

spot_wrapper/spot_world_objects.py Outdated Show resolved Hide resolved
spot_wrapper/wrapper.py Outdated Show resolved Hide resolved
Copy link
Collaborator

It's probably fine then. I would prefer to add the s but it doesn't matter

@khughes-bdai khughes-bdai changed the title [SW-743] Add mutate_world_object functionality to spot_wrapper [SW-743] Add mutate_world_objects functionality to spot_wrapper Feb 20, 2024
tcappellari-bdai

This comment was marked as duplicate.

Copy link
Collaborator

@tcappellari-bdai tcappellari-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@khughes-bdai khughes-bdai merged commit aeb9ab1 into main Feb 21, 2024
3 checks passed
@khughes-bdai khughes-bdai deleted the khughes/mutate_world_object_client branch February 21, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants