Fixes for XML types, such as the sitemap.

controllers/_base.py

@@ -136,6 +136,9 @@ def securityHeaders(self):
         self.set_header('Content-Security-Policy', CSP)
 
     def renderTemplate(self, filename, **kwargs):
+        if filename.endswith('.xml'):
+            self.set_header('Content-Type', 'application/xml')
+
         if self.request.method != 'HEAD':
             self.securityHeaders()
             # could have compile call `self.render` but it looks like a lot of extra processing we don't need

controllers/sitemap.py

@@ -5,7 +5,7 @@
 class SitemapController(BaseController):
     """ handles generating a sitemap """
 
-    @helpers.cacheAndRender()
+    @helpers.cacheAndRender(content_type='application/xml')
     async def get(self):
         # FYI: sitemaps can only have a max of 50,000 URLs or be 10 MB each
         base_url = self.request.protocol + "://" + self.request.host

helpers.py

@@ -117,7 +117,10 @@ async def decorate(*args, **kwargs):
                 await action(*args, **kwargs)
                 html = b"".join(controller._write_buffer).decode()
 
-                html = htmlmin.minify(html, remove_comments=True, remove_empty_space=True)
+                remove_quotes = content_type != 'application/xml'
+
+                html = htmlmin.minify(html, remove_comments=True, remove_empty_space=True,
+                    remove_optional_attribute_quotes=remove_quotes)
 
                 if not controller.debug:
                     cache(key, lambda: html)

readme.md

@@ -1,11 +1,11 @@
 # Trestle
 
-Copyright © 2019, [Brendan Doms](https://www.bdoms.com/)  
+Copyright © 2019-2020, [Brendan Doms](https://www.bdoms.com/)  
 Licensed under the [MIT license](http://www.opensource.org/licenses/MIT)
 
 A jumping off point for building modern web apps.
 
-Uses Python 3, Tornado, and Peewee on the back end, with Vue, Svelte, or no JaaScript on the front end.
+Uses Python 3, Tornado, and Peewee on the back end, with Vue, Svelte, or no JavaScript on the front end.
 
 ## Setup
 
@@ -68,7 +68,7 @@ yarn install
 Make sure postgres is installed (the last dependency on here is for psycopg2 support):
 
 ```bash
-sudo apt install postgresql nginx supervisor libpq-dev
+sudo apt install postgresql libpq-dev
 ```
 
 Then get into postgres:

tests/test_controllers.py

@@ -604,6 +604,7 @@ class TestSitemap(BaseTestController):
     def test_sitemap(self):
         response = self.fetch('/sitemap.xml')
         assert '<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">' in response.body_string
+        assert response.headers.get('Content-Type') == 'application/xml'
 
 
 class TestStatic(BaseTestController):