refactor: clearer data update order for Mailchimp #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpf500
force-pushed
the
feat/1262-mc-fix-update-order
branch
from
116e76a to
87cc2fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the behaviour of
NewsletterService.upsertContactconsistent so its source of truth for a contact is always the object itself. Before there was an ambiguity between whether the contact should be passed to this method before or after having being update. Now it should always happen after the contact update, making the interaction betweenContactServiceandNewsletterServicemuch clearer.It also removes the
shouldUpdateguard, which in practice didn't prevent many (if any) updates, and also reduces the separation of concerns between theContactServiceandNewsletterService.