add extra log

beam-cloud · Mar 5, 2025 · 5c02d63 · 5c02d63
1 parent 9ade02d
commit 5c02d63
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/pkg/worker/lifecycle.go b/pkg/worker/lifecycle.go
@@ -240,7 +240,7 @@ func (s *Worker) RunContainer(ctx context.Context, request *types.ContainerReque
 		InitialSpec: initialBundleSpec,
 	}
 
-	err = s.containerMountManager.SetupContainerMounts(request)
+	err = s.containerMountManager.SetupContainerMounts(request, outputLogger)
 	if err != nil {
 		s.containerLogger.Log(request.ContainerId, request.StubId, fmt.Sprintf("failed to setup container mounts: %v", err))
 	}

diff --git a/pkg/worker/mount.go b/pkg/worker/mount.go
@@ -2,6 +2,7 @@ package worker
 
 import (
 	"fmt"
+	"log/slog"
 	"os"
 	"path"
 
@@ -25,7 +26,7 @@ func NewContainerMountManager(config types.AppConfig) *ContainerMountManager {
 }
 
 // SetupContainerMounts initializes any external storage for a container
-func (c *ContainerMountManager) SetupContainerMounts(request *types.ContainerRequest) error {
+func (c *ContainerMountManager) SetupContainerMounts(request *types.ContainerRequest, outputLogger *slog.Logger) error {
 	// Create local workspace path so we can symlink volumes before the container starts
 	os.MkdirAll(defaultContainerDirectory, os.FileMode(0755))
 
@@ -49,6 +50,7 @@ func (c *ContainerMountManager) SetupContainerMounts(request *types.ContainerReq
 
 			err := c.setupMountPointS3(request.ContainerId, m)
 			if err != nil {
+				outputLogger.Info(fmt.Sprintf("failed to setup mount point s3 error: %w\n", err))
 				return err
 			}
 		}