Skip to content

Commit

Permalink
fix: liveness probe success threshold (#963)
Browse files Browse the repository at this point in the history
Fixes helm upgrades. Should prevent this error.

```
Error: UPGRADE FAILED: cannot patch "beta9-gateway" with kind Deployment: Deployment.apps "beta9-gateway" is invalid: spec.template.spec.containers[0].livenessProbe.successThreshold: Invalid value: 2: must be 1
```

Kustomize seems unaffected and will just correct successThreshold to 1.

Resolve BE-2386
  • Loading branch information
nickpetrovic authored Feb 19, 2025
1 parent b7d0e56 commit 99505d4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion deploy/charts/beta9/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ controllers:
custom: true
spec:
initialDelaySeconds: 10
successThreshold: 2
successThreshold: 1
failureThreshold: 10
periodSeconds: 3
timeoutSeconds: 1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ spec:
port: 1993
livenessProbe:
initialDelaySeconds: 10
successThreshold: 2
successThreshold: 1
failureThreshold: 10
periodSeconds: 3
timeoutSeconds: 1
Expand Down

0 comments on commit 99505d4

Please sign in to comment.