Add instrumentation #1001
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,129 @@ | ||
| package metrics | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "os" | ||
| "time" | ||
|
|
||
| vmetrics "github.com/VictoriaMetrics/metrics" | ||
| "github.com/beam-cloud/beta9/pkg/types" | ||
| "github.com/rs/zerolog/log" | ||
| "tailscale.com/tstime/rate" | ||
| ) | ||
|
|
||
| var ( | ||
| dialMetricLimiter *rate.Limiter | ||
| ) | ||
|
|
||
| const ( | ||
| metricRequestSchedulingDuration = "scheduler_request_scheduling_duration_ms" | ||
| metricRequestRetries = "scheduler_request_retries" | ||
| metricImagePullTime = "worker_image_pull_time_seconds" | ||
| metricImageBuildSpeed = "worker_image_build_speed_mbps" | ||
| metricImageUnpackSpeed = "worker_image_unpack_speed_mbps" | ||
| metricImageCopySpeed = "worker_image_copy_speed_mbps" | ||
| metricImageArchiveSpeed = "worker_image_archive_speed_mbps" | ||
| metricImagePushSpeed = "worker_image_push_speed_mbps" | ||
| metricS3PutSpeed = "s3_put_speed_mbps" | ||
| metricS3GetSpeed = "s3_get_speed_mbps" | ||
| metricDialTime = "dial_time_ms" | ||
| metricContainerStartLatency = "container_start_latency_ms" | ||
| ) | ||
|
|
||
| func InitializeMetricsRepository(config types.VictoriaMetricsConfig) { | ||
| // ENV to collect for default labels | ||
| workerPoolName := os.Getenv("WORKER_POOL_NAME") | ||
| gpuType := os.Getenv("GPU_TYPE") | ||
| podHostname := os.Getenv("POD_HOSTNAME") | ||
|
|
||
| opts := &vmetrics.PushOptions{ | ||
| Headers: []string{ | ||
| fmt.Sprintf("Authorization: Bearer %s", config.AuthToken), | ||
| }, | ||
| } | ||
|
|
||
| if workerPoolName != "" && podHostname != "" { | ||
| opts.ExtraLabels = fmt.Sprintf(`worker_pool_name="%s",pod_hostname="%s"`, workerPoolName, podHostname) | ||
| } | ||
|
|
||
| if gpuType != "" { | ||
| opts.ExtraLabels = fmt.Sprintf(`%s,gpu_type="%s"`, opts.ExtraLabels, gpuType) | ||
| } | ||
|
|
||
| vmetrics.GetDefaultSet().InitPushWithOptions( | ||
| context.Background(), | ||
| config.PushURL, | ||
| time.Duration(config.PushSecs)*time.Second, | ||
| opts, | ||
| ) | ||
|
|
||
| dialMetricLimiter = rate.NewLimiter(2, 1) | ||
| } | ||
|
|
||
| func RecordRequestSchedulingDuration(duration time.Duration, request *types.ContainerRequest) { | ||
| log.Info().Interface("request", request).Msg("recording request scheduling duration") | ||
| metricName := fmt.Sprintf("%s{gpu=\"%s\",gpu_count=\"%d\",cpu=\"%d\",memory=\"%d\"}", | ||
| metricRequestSchedulingDuration, | ||
| request.Gpu, | ||
| request.GpuCount, | ||
| request.Cpu, | ||
| request.Memory) | ||
|
|
||
| vmetrics.GetDefaultSet().GetOrCreateHistogram(metricName).Update(float64(duration.Milliseconds())) | ||
| } | ||
|
|
||
| func RecordRequestRetry(request *types.ContainerRequest) { | ||
| metricName := fmt.Sprintf("%s{container_id=\"%s\",gpu=\"%s\",gpu_count=\"%d\",cpu=\"%d\",memory=\"%d\",retry_count=\"%d\"}", | ||
| metricRequestRetries, | ||
| request.ContainerId, | ||
| request.Gpu, | ||
| request.GpuCount, | ||
| request.Cpu, | ||
| request.Memory, | ||
| request.RetryCount) | ||
|
|
||
| vmetrics.GetDefaultSet().GetOrCreateCounter(metricName).Inc() | ||
| } | ||
|
|
||
| func RecordImagePullTime(duration time.Duration) { | ||
| vmetrics.GetDefaultSet().GetOrCreateHistogram(metricImagePullTime).Update(duration.Seconds()) | ||
| } | ||
|
|
||
| func RecordImageBuildSpeed(sizeInMB float64, duration time.Duration) { | ||
| vmetrics.GetDefaultSet().GetOrCreateHistogram(metricImageBuildSpeed).Update(sizeInMB / duration.Seconds()) | ||
| } | ||
|
|
||
| func RecordImageUnpackSpeed(sizeInMB float64, duration time.Duration) { | ||
| vmetrics.GetDefaultSet().GetOrCreateHistogram(metricImageUnpackSpeed).Update(sizeInMB / duration.Seconds()) | ||
| } | ||
|
|
||
| func RecordImageCopySpeed(sizeInMB float64, duration time.Duration) { | ||
| vmetrics.GetDefaultSet().GetOrCreateHistogram(metricImageCopySpeed).Update(sizeInMB / duration.Seconds()) | ||
| } | ||
|
|
||
| func RecordImageArchiveSpeed(sizeInMB float64, duration time.Duration) { | ||
| vmetrics.GetDefaultSet().GetOrCreateHistogram(metricImageArchiveSpeed).Update(sizeInMB / duration.Seconds()) | ||
| } | ||
|
|
||
| func RecordImagePushSpeed(sizeInMB float64, duration time.Duration) { | ||
| vmetrics.GetDefaultSet().GetOrCreateHistogram(metricImagePushSpeed).Update(sizeInMB / duration.Seconds()) | ||
| } | ||
|
|
||
| func RecordS3PutSpeed(sizeInMB float64, duration time.Duration) { | ||
| vmetrics.GetDefaultSet().GetOrCreateHistogram(metricS3PutSpeed).Update(sizeInMB / duration.Seconds()) | ||
| } | ||
|
|
||
| func RecordS3GetSpeed(sizeInMB float64, duration time.Duration) { | ||
| vmetrics.GetDefaultSet().GetOrCreateHistogram(metricS3GetSpeed).Update(sizeInMB / duration.Seconds()) | ||
| } | ||
|
|
||
| func RecordDialTime(duration time.Duration) { | ||
| if dialMetricLimiter.Allow() { | ||
| vmetrics.GetDefaultSet().GetOrCreateHistogram(metricDialTime).Update(float64(duration.Milliseconds())) | ||
| } | ||
| } | ||
|
|
||
| func RecordContainerStartLatency(duration time.Duration) { | ||
| vmetrics.GetDefaultSet().GetOrCreateHistogram(metricContainerStartLatency).Update(float64(duration.Milliseconds())) | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a bit confused on this, why would it block? the rate limiter doesn't just return if its not "allowed". I could see that other weird issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a mutex inside the rate limiter to acquire the count. Its likely a small and quick acquisition, but it could still block