Fix: Local path should include bucket name for mountpoint s3 #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luke-lombardi
requested changes
Mar 5, 2025
| @@ -42,8 +42,9 @@ func (c *ContainerMountManager) SetupContainerMounts(request *types.ContainerReq | |||
| } | |||
|
|
|||
| if m.MountType == storage.StorageModeMountPoint && m.MountPointConfig != nil { | |||
| log.Info().Interface("mount", m).Interface("config", m.MountPointConfig).Msg("setting up container mounts") | |||
There was a problem hiding this comment.
while we're at this, can we add a warning if the mount fails? i noticed previously that if the creds didnt work it wouldnt show a warning in container logs
pkg/worker/mount.go
Outdated
| request.Mounts[i].LocalPath = m.LocalPath | ||
|
|
||
| err := c.setupMountPointS3(request.ContainerId, m) | ||
| if err != nil { | ||
| outputLogger.Info(fmt.Sprintf("failed to setup mount point s3 error: %v\n", err)) |
There was a problem hiding this comment.
wondering if we should say cloud bucket or something else here? user doesn't know what a mountpoint is since we abstract it behind the sdk thing
luke-lombardi
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If two buckets are mounted, they currently have the same local path. This causes the last bucket to override the prior.