Fix issues with lambda labs machines #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
luke-lombardi
commented
Jun 5, 2024
•
luke-lombardi
commented
- Add optional skip tls verification flag (disabled by default)
- Encapsulate remote config creation into a helper function
- Clean up pool_external and ensure gpu count is set properly on remote machines
- Pass remote config as JSON for simplicity
- Remove secret mount stuff as it's no longer needed if passing config as JSON into an env var
- Add total cpu / total mem / total gpu count fields to track workers maximum capacity
luke-lombardi
changed the title
jsun-m
reviewed
Jun 6, 2024
| @@ -199,10 +204,12 @@ func (wpc *ExternalWorkerPoolController) createWorkerOnMachine(workerId, machine | |||
| return nil, err | |||
| } | |||
|
|
|||
| log.Printf("Created worked: %+v\n", worker) | |||
|
|
|||
| return worker, nil | |||
| } | |||
jsun-m
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.