Add support for content_id in SendgridAdapter #688
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces support for content_id so that inline images in e-mails can be send and referenced from HTML content of the e-mail
|
knock knock |
doomspork
reviewed
Jan 16, 2025
There was a problem hiding this comment.
Hi @hubertlepicki! Apologizes for the delay.
I'm trying to figure out why the GHAs won't run on your branch before I merge. I'd like to make sure all the checks are passing and I can tell they're broken because we're using conventional commits now and your PR should fail that check.
Once I get GHA sorted and we get things ✅ we should be good to go
|
Merged this commit via #691. Not sure why these GHAs aren't queuing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces support for content_id so that inline images in e-mails can be send and referenced from HTML content of the e-mail, when using SendGrid Adapter.