Work with newer Elixir versions #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following Elixir commit elixir-lang/elixir@51d23cb changes how the ~S sigil works when the last character before the delimiter is a backslash
|
Ok. This was introduced with this PR and the test expectation is all sigiled. Can you update that test to a heredoc with the expected text in final form to verify the change works as expected and it's readable without sigils testing sigils? |
|
Someone reported the same this PR fixes (#59) in the Elixir Github issues and Josè reverted the change. This PR is no longer needed. Ref: elixir-lang/elixir#13262 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for #59