This repository has been archived by the owner on May 23, 2023. It is now read-only.
Addresses #58. Added functionality to dsra32 special case. #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PI functionality did to work as intended with an empty function.
beardypig
approved these changes
May 15, 2021
astrelsky
suggested changes
May 15, 2021
There was a problem hiding this comment.
I'm a bit conflicted with how it currently is and with the proposed changes. If this is encountered there would be pcode generated for this that will assign a value to the zero register. Removing the special case entirely would do what you intended as it would be covered by the dsra32 above. However, I think it is more effective to just turn it fully into a nop and put in the comment that it is really dsra32 zero, RTsrc, sa. Having it instead be a nop will prevent the unnecessary zero assignment and should prevent the problem with Rizzo.
|
I'm running short on time, but this pull request is still in my queue. Will try to have it changed and tested before next week. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API functionality did to work as intended with an empty function.