Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up old stuff - including old likelihood native libraries #1189

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rambaut
Copy link
Contributor

@rambaut rambaut commented Jun 28, 2024

This is a large purge of obsolete stuff starting with the oldevomodel/* and oldevomodelxml/ packages that are based around the original TreeLikelihood that uses TreeLikelihoodCore - the original native library. Most uses of this package were simply to get constant strings for parsers that were also available in newer files.

The biggest loss is the whole of the evomodel.arg package which was entirely dependent on oldevolmodel. It was easiest to delete it. Legacy use can be through BEAST v1.10.4 and at some point someone can reimplement using BEAGLE tree likelihoods.

There were a few other things that were easier to delete than to update and have likely been unused for years.

@msuchard
Copy link
Member

msuchard commented Jun 29, 2024

am seeing this error:

    [junit] Running test.dr.evomodel.substmodel.GeneralSubstitutionModelTest
    [junit] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.101 sec

and many, many other errors. @rambaut -- can this wait until after our ..0 release?

@rambaut
Copy link
Contributor Author

rambaut commented Jun 29, 2024

The tests all used the old TreeLikelihood and likelihood core. Which is not much use. I am not sure our unit tests are really worth it at present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants