Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Timezone option to dateTrunc #409

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Timezone option to dateTrunc #409

wants to merge 1 commit into from

Conversation

DennisdeBest
Copy link

The DateTrunc function did not take the optional third timezone argument.

With this change it will work the same if it is not passed but, if you need it, you can add the parameter

@DennisdeBest
Add Timezone option to dateTrunc
3611b6c 
The DateTrunc function did not take the optional third timezone argument.

With this change it will work the same if it is not passed but, if you need it, you can add the parameter
@DennisdeBest
Copy link
Author

Bump ?

laurentmuller
laurentmuller reviewed Aug 12, 2024
View reviewed changes
Copy link

@laurentmuller laurentmuller left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must replace:

$parser->getLexer()->lookahead['type']

By:

$parser->getLexer()->lookahead?->type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentmuller laurentmuller laurentmuller left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DennisdeBest @laurentmuller