-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validating UEI Specification and examples against the Beckn Core specification v 1.1.0 #18
Conversation
Hey @rajaneeshk90 , Please find my comments on the pull request below :
I was hoping you could find the complete difference in the given comparison link (click here). Please make the required change and update the pull request. Thanks |
Hi @emmayank I have fixed the highlighted issues. Can you please review this PR. There are more changes made to fix any non compliance in the UEI spec with the Beckn core specifications version 1.1.0. Please let me know if any clarification is needed. Thanks, |
Adding a "Try it out" button in the ReadMe
Issue:
There are some components of the UEI specification which are not as per the Beckn core specification version 1.1.0
One such issue is highlighted below.
As per the UEI specification, "city" field should be enclosed inside context.location object.
Definition of the context in UEI specification can be found here: https://github.com/beckn/Unified-Energy-Interface/blob/main/api/dent.yaml#L2735
All the JSON examples in the UEI repository directly utilize the "city" field within the context.
More details of the issue can be found on the GitHub issue page of UEI repository: #17
As part of this task, we checked the UEI spec and example JSONs for any non-compliance with Beckn core spec version 1.1.0 and fixed the identified issues.
Change Made
Related ticket: beckn/beckn-ui-workspace#485