-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[!!!][FEATURE] Use the latest Bynder SDK #14
Open
bmoex
wants to merge
5
commits into
beechit:master
Choose a base branch
from
bmoex:upgrade/bynder-sdk
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+398
−559
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b229063
[TASK] Update bynder-php-sdk dependency
bmoex d6aa23e
[!!!][TASK] Update bynder to use the latest SDK
bmoex 9be3eb2
[FEATURE] Refactor signal slots to event listeners
bmoex 5c7a119
[TASK] Simplify configuration array
bmoex 107cbaa
[TASK] Remove unused files and update CGL
bmoex File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,84 @@ | ||
<?php | ||
|
||
namespace BeechIt\Bynder\EventListener; | ||
|
||
use BeechIt\Bynder\Resource\BynderDriver; | ||
use TYPO3\CMS\Core\Database\ConnectionPool; | ||
use TYPO3\CMS\Core\Package\Event\AfterPackageActivationEvent; | ||
use TYPO3\CMS\Core\Resource\StorageRepository; | ||
use TYPO3\CMS\Core\Utility\GeneralUtility; | ||
|
||
class PersistBynderFileStorage | ||
{ | ||
/** @var int */ | ||
private $executionTime; | ||
|
||
/** @var \TYPO3\CMS\Core\Resource\StorageRepository */ | ||
private $storageRepository; | ||
|
||
public function __construct(StorageRepository $storageRepository) | ||
{ | ||
$this->executionTime = $GLOBALS['EXEC_TIME'] ?? time(); | ||
$this->storageRepository = $storageRepository; | ||
} | ||
|
||
/** | ||
* @param \TYPO3\CMS\Core\Package\Event\AfterPackageActivationEvent $event | ||
* @return void | ||
*/ | ||
public function __invoke(AfterPackageActivationEvent $event): void | ||
{ | ||
if ($event->getPackageKey() !== 'bynder') { | ||
return; | ||
} | ||
|
||
if ($this->storageRepository->findByStorageType(BynderDriver::KEY) !== []) { | ||
return; | ||
} | ||
|
||
$this->createBynderStorage(); | ||
} | ||
|
||
/** | ||
* @return void | ||
*/ | ||
private function createBynderStorage(): void | ||
{ | ||
$connectionPool = GeneralUtility::makeInstance(ConnectionPool::class); | ||
|
||
// Create Bynder storage | ||
$field_values = [ | ||
'pid' => 0, | ||
'tstamp' => $this->executionTime, | ||
'crdate' => $this->executionTime, | ||
'name' => 'Bynder', | ||
'description' => 'Automatically created during the installation of EXT:bynder', | ||
'driver' => BynderDriver::KEY, | ||
'configuration' => '', | ||
'is_online' => 1, | ||
'is_browsable' => 1, | ||
'is_public' => 1, | ||
'is_writable' => 0, | ||
'is_default' => 0, | ||
// We use the processed file folder of the default storage as fallback | ||
'processingfolder' => '1:/_processed_/', | ||
]; | ||
|
||
$dbConnection = $connectionPool->getConnectionForTable('sys_file_storage'); | ||
$dbConnection->insert('sys_file_storage', $field_values); | ||
$storageUid = (int)$dbConnection->lastInsertId('sys_file_storage'); | ||
|
||
// Create file mount (for the editors) | ||
$field_values = [ | ||
'pid' => 0, | ||
'tstamp' => $this->executionTime, | ||
'title' => 'Bynder', | ||
'description' => 'Automatically created during the installation of EXT:bynder', | ||
'path' => '', | ||
'base' => $storageUid, | ||
]; | ||
Comment on lines
+72
to
+79
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here |
||
|
||
$dbConnection = $connectionPool->getConnectionForTable('sys_filemounts'); | ||
$dbConnection->insert('sys_filemounts', $field_values); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can pass this directory to the
insert
without instantiating a variable.