(Mostly) Update Aegis to Material 3 #1208
Conversation
for md3 switches in settings
for MD3
MD3 switch
MD3 switches
MD3 Switches
make it more MD3
[2/2] AlertDialog with rounded corners.
Make it more visible
|
Could you please split the changes to polish language from the material you support, it's a little bit confusing. |
|
Tomorrow, i gtg to sleep now🙂 but yeah, sure i can |
|
not bad keep it up your activity.you doing very well strongly appreciated
for your activity.
…On Sun, Oct 8, 2023 at 1:54 AM Wojtaz0w ***@***.***> wrote:
Tomorrow, i gtg to sleep now🙂 but yeah, sure i can
—
Reply to this email directly, view it on GitHub
<#1208 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARKIMZGBMW267E6PRNJ6IELX6G27FAVCNFSM6AAAAAA5XEMJU6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJRHAYTANZUGY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
I'm SURYAPRAKASH
|
There was a problem hiding this comment.
Try a build with MD3: https://github.com/marat2509/Aegis-MD3/actions/runs/6606498800
|
Thanks for the PR. This is a good start, but it looks like there's still quite a bit to do here, and we can't merge partial changes like this. We appreciate the effort, but we think switching to Material 3 is too big of a change to take in as an outside contribution. There'd be too much back and forth over small details, like what colors to use. We should probably have replied sooner to the issue you created back in June. Sorry about that, but like our contribution guidelines states, it's usually best to wait for a proposal to be accepted before starting work on a change. We'll pick the switch to Material 3 up ourselves soon. If you'd like, we can add you as a Co-Authored-By as a token of appreciation. |
|
Cool, love wasting my time 🙃 |
We'd be happy to take those through Crowdin. |
|
Also, since you didn't bother making the switch to MD3 for almost two years, I decided to take matter into my hands only for you to put me off and promise you'll do it someday (you promised already 1 and a half year ago) |
Can't you just merge my commit with translations only? Also I will never create an account on a privacy-invasive website just to translate one app. |
|
I understand the frustration. We are working on this project in our spare time and work on things based on our own priorities. Design or Material 3 in particular never has been high on our list since it's a lot of work/effort for a little return. We rather spend our time fixing bugs or improving the user experience. We've always been transparant about the fact that we can't guarantee features or that we can't give ETA's for new updates or merges, it's ready when it's ready. The offer to add you as a co-author to the Material 3 changes we're going to make still stands.
Unfortunately we can't make exceptions on this: https://github.com/beemdevelopment/Aegis/blob/master/CONTRIBUTING.md#translations. |
|
@Wojtaz0w you can checked out Authenticator Pro, which is another great open source 2FA app except it actually supports MD3, I recently switched to it from Aegis due to the lack of MD3 support in Aegis and it's been great so far (I'm not affiliated with that project in any way) |
Surely you don't have to use your real email address to sign up for that site? You could use an aliasing service like simplelogin or even a disposable email service like 10 minute mail. If you use a trusted VPN (or better still Tor Browser) they also won't have your IP address either and it's pretty much pseudonymous sign up if you dont use real name |
Also update Polish translation.
I'm completely new to Android development, so there may be some mistakes. Please forgive me if there are any. Also if you want me to change something, please let me know.
Issue #1149