#1231 - Fix crash in License and Changelog dialogs on configuration change #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dialog fragments so that they can be recreated on configuration change
michaelschattgen
approved these changes
Nov 29, 2023
|
Looks good to me, thank you for your contribution! |
jsoberg
deleted the
jsoberg/1231/fixing-configuration-change-licensedialog-crash
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all - I just made a PR to fix #1231 vs adding a proposal first since it was a very small and straightforward fix. This PR marks
SimpleWebViewDialogimplementers with public constructors instead of private, so that they can be recreated automatically on a configuration change (circumventing and fixing the linked crash).Let me know if there's anything else I should be adding here. Thanks!