New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read and write requestids for datapoints with HealthKit #419

Merged

theospears merged 1 commit into master from id-for-datapoints

Dec 2, 2023

Collaborator

theospears commented Nov 20, 2023

This prepares for supporting point-by-point syncing of data from HealthKit. In particular

HealthKit data sources now provide a requestid for the datapoints they generate
We always read requestid from the server (now they are always sent)

This will start writing new IDs immediately, and in the future means we can use the IDs to sync when we have multiple datapoints per day.

Testing:

Deleted some existing data points, synced with apple heath, and checked they got requestids as expected
Checked the app can still update existing points via apple health
Confirmed data points still load without crashing


          Include ids when making apple health data points

b40a99f

Collaborator Author

theospears commented Nov 20, 2023

Current dependencies on/for this PR:

master
- PR Read and write requestids for datapoints with HealthKit #419 👈

This stack of pull requests is managed by Graphite.

theospears merged commit 3d6a31a into master

2 checks passed

theospears deleted the id-for-datapoints branch

December 2, 2023 05:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet