Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goal view only sets suggested value once on load #442

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

theospears
Copy link
Collaborator

The goal screen tries to suggest a value based on recent past data.

In the past, this suggestion was updated every time the goal was updated/refreshed (as this might fetch new data). This lead to the user-selected value being overridden at annoying times, for example when navigating away from and returning to the app. Now instead we only set it once at load time. This might lead to stale values e.g. if goal data is out of date, but seems better than the previous behavior.

Testing:
Overrode the value, and checked pull to refresh did not change it
Checked switching away from the app and back did not change the value
Checked going back to the gallery and then back to the goal reset the value

@theospears
Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @theospears and the rest of your teammates on Graphite Graphite

@theospears theospears merged commit a223884 into master Feb 16, 2024
2 checks passed
@theospears theospears deleted the only-set-goal-value-on-load branch February 16, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant