Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade gems #509

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Conversation

krugerk
Copy link
Contributor

@krugerk krugerk commented Nov 6, 2024

@krugerk krugerk changed the title ran bundler update upgrade gems Nov 6, 2024
Gemfile.lock Show resolved Hide resolved
@krugerk krugerk force-pushed the maintenance/bundler-update branch 3 times, most recently from c4c3eb7 to b22536c Compare November 8, 2024 14:28
@theospears
Copy link
Collaborator

theospears commented Nov 10, 2024

When I attempt to run this locally, I see the same infinite stack trace which was showing up in github actions:

> ruby --version
ruby 3.3.6 (2024-11-05 revision 75015d4c1f) [arm64-darwin24]

It looks like you worked around this for github actions via downgrade, but this is a pain locally as brew doesn't carry older versions, so we should probably hold off until this is fixed with latest ruby?

@krugerk
Copy link
Contributor Author

krugerk commented Nov 10, 2024

When I attempt to run this locally, I see the same infinite stack trace which was showing up in github actions:

> ruby --version
ruby 3.3.6 (2024-11-05 revision 75015d4c1f) [arm64-darwin24]

It looks like you worked around this for github actions via downgrade, but this is a pain locally as brew doesn't carry older versions, so we should probably hold off until this is fixed with latest ruby?

Locally I have rbenv where I have set ruby-version 3.3.5 for this repository.

@theospears
Copy link
Collaborator

theospears commented Nov 11, 2024

It looks like this works with ruby 3.3.6 if we upgrade to the latest version of bundler (see https://github.com/orgs/community/discussions/143096 and I've also verified locally this works) so maybe let's do that?

@theospears theospears merged commit 919059a into beeminder:master Nov 11, 2024
1 check passed
@krugerk krugerk deleted the maintenance/bundler-update branch November 12, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants