Migrate from CoreData to SwiftData #514
Closed
+167
−348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theospears
changed the title
|
This is the first working version. I need to read over the diff and also locally do some more validation that it isn't totally broken before merging. I intend to merge the smallest diff that basically works here to minimize the merge conflict window, and then follow up with more cleanup afterwards. |
theospears
force-pushed
the
swift-data
branch
from
ead316a
to
47d9f8f
Compare
|
Overall it seems like SwiftData isn't mature enough to use yet (see e.g. https://developer.apple.com/forums/thread/759364). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates BeeSwift from CoreData to SwiftData. Data is not migrated, but this is fine as we have not done a public release based on CoreData. This is intended to be a minimal migration. In particular it does not yet make use of
@ModelActorwhich will be needed to get the concurrency behavior right.Note this removes Spotlight support as there isn't yet a handy helper for that with SwiftData like there is with core data. We'll need to write a little bit of manual code to bring that back.
Testing:
Verified the app launches, logs in, and can view gallery and goal page