show when healthkit linked goal was last synced with healthkit #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krugerk
commented
Jan 2, 2025
BeeSwift/GoalViewController.swift
Outdated
|
|
||
| private func refreshPullDown() { | ||
| let dateFormatter = ISO8601DateFormatter() | ||
| dateFormatter.formatOptions = [.withFullDate, .withFullTime] |
|
Proposal: strip that down to nothing but HH:MM -- no date, no seconds, no am/pm, no timezone, nothing. I would've thought that too extreme but it's what Stripe does on their mobile app and I realized it works because you figure it out by experimentation. |
krugerk
force-pushed
the
feature/when-was-goal-last-synced-with-apple-health
branch
from
26eb85c to
c2374bb
Compare
updated to show date too (in user's preferred format) when last sync was not in the same day and to show the time in the user's preferred format |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The user can see the most recent datapoints and can infer from that when the last sync took place. This PR displays the date directly so the user need not infer when that might have been.
For UI changes including screenshots of before and after is great.
when synced today
showing time
previous
showing the full date/time
Validation
ran app in simulator
Tickets
Fixes #193