Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for empty album and handle them gracefully #5548

Closed
wants to merge 5 commits into from

Conversation

arsaboo
Copy link
Contributor

@arsaboo arsaboo commented Dec 15, 2024

Description

Fixes #5540 (comment)

  • Changelog. (Add an entry to docs/changelog.rst to the bottom of one of the lists near the top of the document.)
  • Tests. (Very much encouraged but not strictly required.)

@arsaboo
Copy link
Contributor Author

arsaboo commented Dec 15, 2024

@snejus I tested this and can confirm that it works.

Copy link
Member

@snejus snejus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm now thinking: how come do you have empty albums in your library? 😅

docs/changelog.rst Outdated Show resolved Hide resolved
@arsaboo
Copy link
Contributor Author

arsaboo commented Jan 1, 2025

Haha...I wish I knew 😜

Co-authored-by: Šarūnas Nejus <[email protected]>
@Serene-Arc
Copy link
Contributor

Perhaps we should add a function to beet update to purge these empty albums? We use the update command to do a lot of cleanup and other functions, so this might be good to fold in. Is there a reason we'd want to keep empty albums in a library database?

@snejus
Copy link
Member

snejus commented Jan 10, 2025

Is there a reason we'd want to keep empty albums in a library database?

Definitely not. The funny thing here is that beets never ends up adding empty albums in the first place. The only times I've come across empty albums in my library have been when this happened due to some funky adjustments I made in the source. Could this potentially be the reason why you have them as well @arsaboo?

@arsaboo
Copy link
Contributor Author

arsaboo commented Jan 11, 2025

Indeed, it's quite possible those empty albums were created during one of my many tests. We can close this PR for now. If it's comes back again, we can remove the empty albums (which may be a better solution). Unfortunately, I am unable to reproduce it right now to fix it.

@arsaboo arsaboo closed this Jan 12, 2025
@arsaboo arsaboo deleted the mbsync branch January 12, 2025 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants