-
-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump tox from 4.10.0 to 4.11.0 #1426
Conversation
In case #1360 doesn't merge very soon....let's merge this to fix this RTD build issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very weird... 4.10 builds were working fine 2 days ago when I merged the dependabot change... and there's nothing in the 4.11 release notes about a bug fix. I can only assume there's something pinned differently in tox's dependencies?
This PR looks good; I'll hold off merging it until I've reviewed #1360 (which is next on my list). If I can merge that, then there's a little less commit churn.
Good deal; this PR is only a contingency plan.
The failure is happening on the
Given the reference to "config_settings", I'm thinking it might be this...??? |
I've just approved that PR; once CI finishes, I'll merge - so I'll close this PR. Yeah - but wheel, setuptools, virtualenv or build haven't had a release since Monday... I'm at a loss for what has changed that has caused 4.10 builds to stop working. Anyway - 4.11 builds are working, so it's a moot point. |
Changes
tox
is failing RTD builds for some reason; bump to 4.11.0PR Checklist: