This repository has been archived by the owner on May 31, 2020. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 518
Nonlocal statement support #854
Merged
freakboy3742
merged 32 commits into
beeware:master
from
BPYap:nonlocal-statement-support
Aug 7, 2018
Merged
Nonlocal statement support #854
freakboy3742
merged 32 commits into
beeware:master
from
BPYap:nonlocal-statement-support
Aug 7, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6860a1d.
@freakboy3742, passing Well, some part of the code may still be further enhanced to be more efficient. |
freakboy3742
approved these changes
Aug 7, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 It took a while, but we finally got there! This looks a lot cleaner - excellent work!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nonlocal is used in some built-in module (e.g. tasks.py in asyncio module). Support for
nonlocal
statement should enable a number of files inKNOWN_PROBLEM_MODULES
to compile.Refer to GSOC week 10/11 log for implementation details.
New features added in this PR:
nonlocal
is now supported in function closure and generator closure. e.g: