Binary media types list #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackKelly-Bellroy
force-pushed
the
binary-media-types-list
branch
from
6efa977
to
6d0120b
Compare
lrworth
reviewed
Jan 16, 2024
JackKelly-Bellroy
force-pushed
the
binary-media-types-list
branch
from
6d0120b
to
f738f70
Compare
A careful reading between the lines of the [API Gateway documentation][1] implies that if `binaryMediaTypes` is not set on the API Gateway, all responses are considered to be text. So we should be able to get away with an explicit list of media types that require binary responses, and we can ask the developer to ensure that it matches the `binaryMediaTypes` setting on his or her API. [1]: https://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-payload-encodings-workflow.html
JackKelly-Bellroy
force-pushed
the
binary-media-types-list
branch
from
f738f70
to
6a5f750
Compare
|
Published as 0.4.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A careful reading between the lines of the API Gateway documentation implies that if
binaryMediaTypesis not set on the API Gateway, all responses are considered to be text. So we should be able to get away with an explicit list of media types that require binary responses, and we can ask the developer to ensure that it matches thebinaryMediaTypessetting on his or her API.Also document accidental breakage and improve ergonomics. @jaspervdj I'd be interested to hear if this works better for you than
0.3.0.0.