-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor GameDisplay #827
base: master
Are you sure you want to change the base?
Refactor GameDisplay #827
Conversation
Codecov ReportBase: 86.39% // Head: 86.21% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #827 +/- ##
==========================================
- Coverage 86.39% 86.21% -0.19%
==========================================
Files 178 178
Lines 5366 5374 +8
Branches 382 426 +44
==========================================
- Hits 4636 4633 -3
- Misses 676 682 +6
- Partials 54 59 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
c7a6fe8
to
9e8dcce
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@dtinth Excuse me, could you review my PR? I forgot this. |
@MikuroXina Hello, I really apologize. I am currently very occupied with other stuff right now and probably do not have time to develop this project for a few months. 🙏 From a quick glance the code looks good to me, although I can’t play-test the game right now. For the time being, please feel free to publish a forked version, and feel free to ask me if you need any help. |
For types,
@types/jquery
is added andscreenfull
is bumped.