Send CryptKey instance to oauth2 with new permission check disabled #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on vagrant/windows
…e set to the public key. Also passing a CryptKey instance here fails
jonathonsim
commented
Apr 23, 2018
src/JwtClaimsServiceProvider.php
Outdated
| @@ -32,7 +33,7 @@ public function makeAuthorizationServer() | |||
| $this->app->make(AccessTokenRepository::class), // BenBjurstrom\JwtClaims\AccessTokenRepository | |||
| $this->app->make(ScopeRepository::class), | |||
| new CryptKey( 'file://'.Passport::keyPath('oauth-private.key'), null, false ), | |||
| new CryptKey('file://'.Passport::keyPath('oauth-public.key'), null, false ) | |||
| app('encrypter')->getKey() | |||
There was a problem hiding this comment.
@benbjurstrom FYI, my original commit here was wrong (this second argument is expected to be a secret encryption key as a string, rather than a CryptKey instance.
However looking at the upstream they use app('encrypter')->getKey() here rather than the public key and as far as I can see this key is supposed to be a private secret string unique to the app rather than a filename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running in some development environments, eg Vagrant on Windows (or most other methods you might use to develop in windows, eg docker or a local PHP install) it's impossible to make the oauth-private.key file match the exact permissions that thephpleague/oauth2-server now checks for, and this means everything will fail with an exception
Passport fixed this in this PR laravel/passport#454 and this code implements a similar solution in benbjurstrom/passport-custom-jwt-claims