ENH: add to_wkb / from_wkb #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The upstream change is merged in s2georaphy, so this should be ready now |
benbovy
reviewed
Nov 17, 2024
| } | ||
|
|
||
| private: | ||
| std::shared_ptr<s2geog::WKBReader> m_reader; |
There was a problem hiding this comment.
Use unique_ptr instead of shared_ptr? (Also in ToWKB) Unless I'm missing something?
There was a problem hiding this comment.
It might be that pybind11 requires this class to be copyable? (if you pass it as argument to vectorize)
And that then gives the typical "use of deleted function" compilation errors if using unique_ptr instead of shared_ptr
Co-authored-by: Benoit Bovy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on paleolimbot/s2geography#42
Closes #38