-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build baseline #206
Closed
Closed
Build baseline #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-picked from 07f2215
Cherry-pick from 6ce4e72
As those creeps have a push priority of 0, the check would fail and default them, defeating the push protection entirely.
This switches to Node 18 and more recent version of most dependencies
There was a logic error in the AnyZerg move() method, causing the issue in Movement.vacatePos(). The method vacatePos() sets creep.blockMovement to true, but is meant to override it with force: true. The check in AnyZerg said "!this.blockMovement && !force" therefore this method was not working, and the creep not moving. Swapped it to "!this.blockMovement || force". Also fixed an issue where Zergs of a role would stop working if one of their kind was spawning, there was a return instead of an continue, aborting any Zerg actions after it. Squashed from eb2b78c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request summary
Description:
This is the first part of the massive amounts of changes I had to make to get it to build and run after so long, so mostly tooling and updates, gathering various changes across the community, with a few small functional changes thrown in (mostly around ruins and tombstones), which I'll describe below.
Added:
Room
.Changed:
Store
class.findBlockingPos
works across rooms now, because MiningOverlord uses it and it was throwing errors.Task
gained a generic parameter for its target type. I don't remember why I did that; I think I was chasing after a crashing invalid task, or maybe something aboutTaskRecharge
.Fixed:
Testing checklist:
Memory
.tsconfig
configuration