Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RoomObject.print #211

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

RoomObject.print #211

wants to merge 1 commit into from

Conversation

tiennou
Copy link

@tiennou tiennou commented Feb 3, 2024

Pull request summary

Description:

This adds a RoomObject-level .print method, so that it's safe to print any sort of object. I believe it is missing a couple cases, but it covers most of them.

Testing checklist:

  • Changes are backward-compatible
  • Codebase compiles with current tsconfig configuration
  • Tested changes on private server

bencbartlett
bencbartlett requested changes Feb 4, 2024
View reviewed changes
Copy link
Owner

@bencbartlett bencbartlett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments; please don't include changes to unrelated files in future pull requests, such as editorconfig, gitignore, toolversions, obfuscator, etc. Try to include only the changes which are relevant to the feature you are making the PR for

package.json Outdated Show resolved Hide resolved
rollup.config.js Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
obfuscator.config.json Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
.editorconfig Outdated Show resolved Hide resolved
tools/make-public.js Outdated Show resolved Hide resolved
src/declarations/index.d.ts Outdated Show resolved Hide resolved
src/declarations/typeGuards.ts Outdated Show resolved Hide resolved
src/prototypes/RoomObject.ts Outdated Show resolved Hide resolved
@tiennou
Copy link
Author

tiennou commented Feb 5, 2024

Tooling changes removed, and changed the typeguards to use explicit structural checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bencbartlett bencbartlett bencbartlett requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiennou @bencbartlett