-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Green model to benchmark - follow up #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for the follow up.
Before merging, can you share a screen shot of the result on BNCI competition with one competitor like CSP-LDA
?
The |
Could you indicate the problematic dependencies? |
It is not completely clear as I could not pinpoint exactly which dependency caused the issue but in #13, skipping |
Ok it seems that the error was mostly bad interactions with another error with the latest version of scikit-learn. |
I tried to solve this in Roche/neuro-green#6, hope it's better now. |
Seems much better! thanks @jpaillard :) |
Following up on #39 this integrates the review from @tomMoral