Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: error when hitting <c-q> to send content to quickfix windows in Telescope picker #30

Merged
merged 3 commits into from
Dec 14, 2024

Conversation

benfowler
Copy link
Owner

This PR is for @pdckxd 's quick-fix window fix. I merged this change earlier, and things regressed, so I'm reopening as draft to investigate.

Tracked as issue #29 .

pdckxd and others added 3 commits December 7, 2024 03:20
Appears to be required for Telescope to display the snippets list at
all.  See the Telescope developer's documentation here:

<https://github.com/nvim-telescope/telescope.nvim/blob/master/developers.md#entry-maker>
Not consistent with Telescope plugins' quickfix output from other
pickers.  Aligning with them for consistency.
@benfowler benfowler marked this pull request as ready for review December 7, 2024 04:21
@benfowler
Copy link
Owner Author

@pdckxd : I've re-tested, and modified your change to reinstate a line you removed in your PR -- the ordinal attribute of the entry object in the row generation function. It appears to be mandatory.

I've done some testing locally. I've also wiped my Lazy plugin cache and tested again under a clean install to verify it works with a clean Neovim install.

@benfowler
Copy link
Owner Author

@pdckxd , I haven't heard back, and I've been using this branch for a week without issue. I'm going to just go ahead and merge it.

@benfowler benfowler merged commit 127dac8 into master Dec 14, 2024
@benfowler benfowler deleted the reinvestigateQuickFixBreakage branch December 14, 2024 01:57
@pdckxd
Copy link
Contributor

pdckxd commented Dec 15, 2024

@benfowler ,didn't get chance to see inbox for several weeks. Thanks to take the MR.

@benfowler
Copy link
Owner Author

@pdckxd you're welcome! I hope that problem is solved for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants